Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix action_history being opposite sign #19

Closed
wants to merge 1 commit into from

Conversation

Quantizr
Copy link
Contributor

Fixes #18

All leaderboard submissions need to be rerun. Default pid score goes from 147.506 to 141.3.

@haraschax
Copy link
Contributor

Ok, thanks. Looking into where this actually comes from.

@haraschax
Copy link
Contributor

haraschax commented Jun 19, 2024

Ok I think I figured out where it went wrong. The car APIs generally use a convention where positive torque means turning left. (this is from some dumb convention called ENU). Almost everywhere we use right-positive (NED from aviation). We converted the dataset prior to training but not here on loading it seems.

@haraschax
Copy link
Contributor

Can you just add the negative sign to line 120 instead? And then add some comment like "car torque commands are logged with left-positive convention but this simulator uses right-positive"

@haraschax haraschax closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

action_history before CONTROL_START_IDX is opposite sign
2 participants