Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent use of (Truncated)MiniCartBeanFactory #681

Open
selo-ecube opened this issue Oct 19, 2017 · 0 comments
Open

Inconsistent use of (Truncated)MiniCartBeanFactory #681

selo-ecube opened this issue Oct 19, 2017 · 0 comments
Labels
Milestone

Comments

@selo-ecube
Copy link

selo-ecube commented Oct 19, 2017

  • MiniCartControllerComponent uses CartInSession to find an existing Cart and MyCartBeanFactory to create an empty Cart if no Cart exists for the session, yet.
  • CartInSession uses TruncatedMiniCartBeanFactory to create a truncated MiniCartBean when serializing a Cart into the session cookie.
  • The use of MiniCartBeanFactory to create an empty Cart and a TruncatedMiniCartBeanFactory to serialize a non-empty Cart confused me when I was looking for the cause of a bug and makes it harder to introduce a subtype of MiniCartBean. Using TruncatedMiniCartBeanFactory / CartInSession.createMiniCart(...) would require additional null checks in TruncatedMiniCartBeanFactory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants