Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error messages for value_and_pullback #111

Closed
willtebbutt opened this issue Apr 2, 2024 · 1 comment
Closed

Error messages for value_and_pullback #111

willtebbutt opened this issue Apr 2, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone
Things to get don...

Comments

@willtebbutt
Copy link
Member

https://github.com/gdalle/DifferentiationInterface.jl/pull/126/files#r1546421316 highlights that it's possible to get really uninformative error messages when the wrong types are passed to value_and_pullback!! -- this should be improved, and some dynamic checking should be (optionally) enabled to ensure that the tangents are valid etc.
@willtebbutt willtebbutt added enhancement New feature or request documentation Improvements or additions to documentation labels Apr 29, 2024
@willtebbutt willtebbutt added this to the A Milestone milestone May 13, 2024
@willtebbutt
Copy link
Member Author

Things have actually moved on quite a bit from here -- there are now some type checks in the interface. The thing that really need to happen is #146 -- so I'm closing this in favour of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
Things to get done before writing
Development

No branches or pull requests
1 participant
@willtebbutt