Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gasLimit seems not considered properly #16

Open
michael-spengler opened this issue Jan 15, 2021 · 2 comments
Open

gasLimit seems not considered properly #16

michael-spengler opened this issue Jan 15, 2021 · 2 comments

Comments

@michael-spengler
Copy link

michael-spengler commented Jan 15, 2021

Hi compound-js team.

I'm very happy about your library and so far everything worked as documented and expected. One thing seems unclear to me:

I triggered a supply transaction with a gasLimit set to 250000 - however the gas price paid according to etherscan.io... was higher than 250000 GWEI --> 0.00025 Ether (if I understood things correctly):

        const trxOptions = { gasLimit, mantissa: false }

        try {
            const trx = await compound.supply(Compound.ETH, amountOfEtherToBeDeposited, trxOptions)
            console.log(`You can check the deposit to compound transaction at https://etherscan.io/tx/${trx.hash}`)
        } catch (error) {
            console.log(`Something went wrong while depositing Ether to compound.finance: ${error.message}`)
        }

So my inquiry is: Is it possible that the gasLimit is not taken into consideration properly by the implementation?

@ajb413
Copy link
Collaborator

ajb413 commented Jan 15, 2021

Hmm.. This parameter is passed into the Ethers.js transaction. I can look at your transaction hash on etherscan if you'd like. Feel free to DM me in Discord.

@michael-spengler
Copy link
Author

@ajb413
Hi Adam. Thank you. I just posted the inquiry in the support-help channel in order to find out your discord handle: https://discord.com/channels/402910780124561410/765610989847969810/799916325756993536

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants