From e518b3b51de2c394f286b0ffa303098f6758bc3e Mon Sep 17 00:00:00 2001 From: Kor de Jong Date: Tue, 12 Sep 2023 09:37:25 +0200 Subject: [PATCH] lue.{data_model,framework,qa} are regular shared libs} --- source/data_model/python/CMakeLists.txt | 3 --- source/framework/python/CMakeLists.txt | 7 ------- source/qa/python/CMakeLists.txt | 7 ------- 3 files changed, 17 deletions(-) diff --git a/source/data_model/python/CMakeLists.txt b/source/data_model/python/CMakeLists.txt index 8af778eb3..14a730c16 100644 --- a/source/data_model/python/CMakeLists.txt +++ b/source/data_model/python/CMakeLists.txt @@ -96,7 +96,6 @@ target_compile_definitions(lue_py_data_model set_target_properties(lue_py_data_model PROPERTIES - RUNTIME_OUTPUT_DIRECTORY $ CXX_CLANG_TIDY "" # TODO(KDJ) Get it to skip pybind11.h ) @@ -117,8 +116,6 @@ target_link_libraries(lue_py_data_model nonstd::span-lite ) -pybind11_extension(lue_py_data_model) - # TODO pybind11_strip does not work on macOS, when building using Conda packages # The resulting binary can't be imported. Results in "killed: 9". if(NOT MSVC AND NOT APPLE AND NOT ${CMAKE_BUILD_TYPE} MATCHES Debug|RelWithDebInfo) diff --git a/source/framework/python/CMakeLists.txt b/source/framework/python/CMakeLists.txt index 4462cdf28..7b44d60f8 100644 --- a/source/framework/python/CMakeLists.txt +++ b/source/framework/python/CMakeLists.txt @@ -154,11 +154,6 @@ target_compile_definitions(lue_py_framework NPY_NO_DEPRECATED_API=NPY_1_7_API_VERSION ) -set_target_properties(lue_py_framework - PROPERTIES - RUNTIME_OUTPUT_DIRECTORY $ -) - target_include_directories(lue_py_framework PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/../../data_model/python/include @@ -183,8 +178,6 @@ target_link_libraries(lue_py_framework pybind11::windows_extras ) -pybind11_extension(lue_py_framework) - # TODO pybind11_strip does not work on macOS, when building using Conda packages # The resulting binary can't be imported. Results in "killed: 9". if(NOT MSVC AND NOT APPLE AND NOT ${CMAKE_BUILD_TYPE} MATCHES Debug|RelWithDebInfo) diff --git a/source/qa/python/CMakeLists.txt b/source/qa/python/CMakeLists.txt index cc162ee93..d8e1b2553 100644 --- a/source/qa/python/CMakeLists.txt +++ b/source/qa/python/CMakeLists.txt @@ -12,11 +12,6 @@ if(LUE_QA_WITH_PYTHON_API) add_library(lue::py_qa ALIAS lue_py_qa) - set_target_properties(lue_py_qa - PROPERTIES - RUNTIME_OUTPUT_DIRECTORY $ - ) - target_include_directories(lue_py_qa PUBLIC $ @@ -32,8 +27,6 @@ if(LUE_QA_WITH_PYTHON_API) pybind11::windows_extras ) - pybind11_extension(lue_py_qa) - # TODO pybind11_strip does not work on macOS, when building using Conda packages # The resulting binary can't be imported. Results in "killed: 9". if(NOT MSVC AND NOT APPLE AND NOT ${CMAKE_BUILD_TYPE} MATCHES Debug|RelWithDebInfo)