Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Garden properties are always included even when using containerd runtime #115

Open
andy-paine opened this issue Aug 13, 2020 · 0 comments
Open

Garden properties are always included even when using containerd runtime #115

andy-paine opened this issue Aug 13, 2020 · 0 comments

Comments

@andy-paine
Copy link

Bug Report

The env.sh script generated by BOSH (via the Go templating -> ERB templating) always contains the following flags (since they have defaults defined in the spec:

  • CONCOURSE_GARDEN_ALLOW_HOST_ACCESS
  • CONCOURSE_GARDEN_MAX_CONTAINERS
  • CONCOURSE_GARDEN_NETWORK_POOL

This causes an issue when selecting runtime: containerd as Concourse won't allow Garden options when using the containerd runtime.

The following can also be handy:

  • Concourse version: 6.4.1 (actually, master of this repo)
  • Deployment type (BOSH/Docker/binary): BOSH (obviously? 😁)
  • Infrastructure/IaaS: AWS
  • Browser (if applicable): N/A
  • Did this used to work? New feature.

NB: I'm aware that this is a very new feature so don't expect it to work perfectly but since I was taking it for a spin I figured that pointing out the issues I came across would be helpful! I was looking at fixing it by adding some ERB bits to only include relevant flags based on which runtime is selected but the Go templating stuff isn't really set up for only selecting certain properties from the spec file and I didn't want to be too opinionated on changes without discussing with the team first.
@andy-paine andy-paine mentioned this issue Aug 13, 2020
Closed
andy-paine added a commit to EngineerBetter/concourse-bosh-release that referenced this issue Aug 13, 2020
@andy-paine
Add a runtime flag to spec files
9894c7f 
Only one of CONCOURSE_CONTAINERD_* and CONCOURSE_GARDEN_* sets of
options should be set. Add a flag in the spec file that the envgen
helper uses to generate ERB files that correctly represent this need.
Defaults to Guardian since that is the implicit default in Concourse.

Fixes concourse#115
@andy-paine andy-paine mentioned this issue Aug 13, 2020
Closed
andy-paine added a commit to EngineerBetter/concourse-bosh-release that referenced this issue Aug 13, 2020
@andy-paine
Add a runtime flag to spec files
dbba54f 
Only one of CONCOURSE_CONTAINERD_* and CONCOURSE_GARDEN_* sets of
options should be set. Add a flag in the spec file that the envgen
helper uses to generate ERB files that correctly represent this need.
Defaults to Guardian since that is the implicit default in Concourse.

Fixes concourse#115

Signed-off-by: Andy Paine <andy.paine@engineerbetter.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a runtime flag to spec files EngineerBetter/concourse-bosh-release
1 participant
@andy-paine