-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the sslnegotiation DSN option #11
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Mathias Bogaert <mathias.bogaert@gmail.com>
Hi @taylorsilva, please review, this adds support for the sslnegotiation parameter. A new parameter in Postgres 17 allows for direct TLS handshakes, reducing network latency and improving the performance of secure connections. |
Signed-off-by: Taylor Silva <dev@taydev.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, the tests pass. Only thing I'm not sure about is if this requires lib/pq
to support this feature? I don't know enough about what limits the driver places on us in regards to version specific features like this.
Seeing issues like this one in the lib/pq project makes me think this won't do anything 🙁
lib/pq#1175
Yeah looking at https://github.com/lib/pq/blob/master/ssl.go |
Adding this feature to lib/pq should just be a case of adding an if statement around https://github.com/lib/pq/blob/3d613208bca2e74f2a20e04126ed30bcb5c4cc27/conn.go#L1116-L1130. Indeed a question whether the maintainers will respond to such a patch, however. I'll open one |
No description provided.