Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes selection is lost after using component property controls #5982

Closed
maltenuhn opened this issue Jun 18, 2024 · 3 comments
Closed

Sometimes selection is lost after using component property controls #5982

maltenuhn opened this issue Jun 18, 2024 · 3 comments
Assignees
Labels
Blocked Bug Something isn't working

Comments

@maltenuhn
Copy link
Member

E.g. setting the padded property of a column.
I don't know how to reliably reproduce, but e.g. if you recreate the whole page building session of the demo there is high chance it is going to happen: https://paper.dropbox.com/doc/Building-the-Demo-Script--CRN8vYvyL8yZF6pJ6frX939uAg-Qtq5516kayWxUvkcCwOfT#:uid=430181461514264433643542&h2=Inserting-the-title-and-the-st

@maltenuhn maltenuhn added the Bug Something isn't working label Jun 18, 2024
@balazsbajorics
Copy link
Contributor

what I would try first is check the places in the code that trigger a print-> reparse cycle, and make sure that we print with the UIDs kept in, not stripped away. In theory that should prevent any bugs that arise from a non-stable UID messing with selection. Once this is confirmed to fix the bug, we "just" need to prevent the editor from sending printed code with the UIDs over the vscode bridge.

(Come to think of it, maybe we could strip the UIDs right before sending it over the bridge, and otherwise keep it at all times?)

@ruggi ruggi mentioned this issue Jun 20, 2024
2 tasks
@ruggi ruggi self-assigned this Jun 20, 2024
@maltenuhn
Copy link
Member Author

I've moved this back because I don't know if we positively confirmed the root cause of this, and that this is now definitively solved. Mentioned previously were a) the VSCode bridge (soon to be pulled down), and b) the new UUIDs (now 1000% more unique!).

If either or both-in-conjunction is likely to have solved this, we should close this ticket (and open a new one if it happens again).
cc @Rheeseyb and @ruggi

@Rheeseyb
Copy link
Contributor

Closing as I'm unable to repro this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants