Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the various mouseup / mousedown behaviours in the editor #6226

Closed
maltenuhn opened this issue Aug 12, 2024 · 0 comments
Closed

Clean up the various mouseup / mousedown behaviours in the editor #6226

maltenuhn opened this issue Aug 12, 2024 · 0 comments
Assignees

Comments

@maltenuhn
Copy link
Member

maltenuhn commented Aug 12, 2024

Problem
Our handling of UI controls has regressed / become inconsistent in terms of what activates onMouseDown vs onClick / onMouseUp. Here is a list of the behaviours we should change.

We should also make sure that all buttons that activate on click get a hover state.

Navigator onMouseDown

  • Navigator tabs (file browser etc)
  • Navigator item
  • eye and lock icons
  • insert / change buttons (?)
  • expand arrows for scenes
  • expand arrows for items

Inspector onMouseDown

  • Inspector tabs (Inspector / Comments / Settings etc)
  • Expandable sections (when you click on the heading / expansion arrow) ie Styled, Image, Advanced, etc
  • Any expansion indicator (including component prop tree view)

Inspector onClick

  • [+] and [-] buttons eg for grid (should also highlight on hover)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants