Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix striped area size when changing grid gap per row/column #6562

Closed
ruggi opened this issue Oct 17, 2024 · 0 comments · Fixed by #6563
Closed

Fix striped area size when changing grid gap per row/column #6562

ruggi opened this issue Oct 17, 2024 · 0 comments · Fixed by #6563
Assignees
@ruggi

Comments

@ruggi
Copy link
Contributor

ruggi commented Oct 17, 2024

No description provided.

@ruggi ruggi self-assigned this Oct 17, 2024
@ruggi ruggi mentioned this issue Oct 17, 2024
Merged
@ruggi ruggi closed this as completed in b27dfa8 Oct 18, 2024
liady pushed a commit that referenced this issue Dec 13, 2024
@ruggi @liady
Fix grid resize striped area length with per-axis gap (#6563)
dbecbb8 
**Problem:**

When changing the grid gap via the canvas the row/column specific gap is
set (or using the split gap in the inspector), but it's not taken into
account when calculating the striped area length for grid resize.

**Fix:**

Take the `rowGap` / `columnGap` props into account when calculating the
striped area length in addition to the `gap` shorthand.

Fixes #6562
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruggi ruggi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix grid resize striped area length with per-axis gap concrete-utopia/utopia
1 participant
@ruggi