Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GridExpressionInput's border radius and highlight color conditions #6575

Closed
ruggi opened this issue Oct 22, 2024 · 0 comments · Fixed by #6576
Closed

Fix GridExpressionInput's border radius and highlight color conditions #6575

ruggi opened this issue Oct 22, 2024 · 0 comments · Fixed by #6576
Assignees
@ruggi

Comments

@ruggi
Copy link
Contributor

ruggi commented Oct 22, 2024

No description provided.

@ruggi ruggi self-assigned this Oct 22, 2024
@ruggi ruggi mentioned this issue Oct 22, 2024
Merged
ruggi added a commit that referenced this issue Oct 22, 2024
@ruggi
Fix GridExpressionInput's border radius and highlight color conditions (
5195936 
#6576)

**Problem:**

The border highlight of selected `GridExpressionInput` components should
stay active while the dropdown is open. Also, the border radius should
use the theme's value.

**Fix:**

Fix the inset shadow conditions so that the border is shown as blue if
the _text_ input is focused (not the container), or the dropdown is
open, even if the mouse is not over the dropdown trigger.

In addition, update the border radius size with
`UtopiaTheme.inputBorderRadius`.


| Before | After |
|--------|----------|
| ![Kapture 2024-10-22 at 13 30
43](https://github.com/user-attachments/assets/4a56bc21-3fcd-4531-9632-20eb2d3aa6f6)
| ![Kapture 2024-10-22 at 13 29
21](https://github.com/user-attachments/assets/15c397d5-db82-4af9-9fd3-9b53ff3032d9)
|

Fixes #6575
liady pushed a commit that referenced this issue Dec 13, 2024
@ruggi @liady
Fix GridExpressionInput's border radius and highlight color conditions (
efc20aa 
#6576)

**Problem:**

The border highlight of selected `GridExpressionInput` components should
stay active while the dropdown is open. Also, the border radius should
use the theme's value.

**Fix:**

Fix the inset shadow conditions so that the border is shown as blue if
the _text_ input is focused (not the container), or the dropdown is
open, even if the mouse is not over the dropdown trigger.

In addition, update the border radius size with
`UtopiaTheme.inputBorderRadius`.


| Before | After |
|--------|----------|
| ![Kapture 2024-10-22 at 13 30
43](https://github.com/user-attachments/assets/4a56bc21-3fcd-4531-9632-20eb2d3aa6f6)
| ![Kapture 2024-10-22 at 13 29
21](https://github.com/user-attachments/assets/15c397d5-db82-4af9-9fd3-9b53ff3032d9)
|

Fixes #6575
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruggi ruggi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix GridExpressionInput's border radius and highlight color conditions concrete-utopia/utopia
1 participant
@ruggi