Move grid placement section below layout, use self alignment icons for grid/flex children #6502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#14668 Bundle Size — 57.74MiB (~+0.01%).a681e28(current) vs 916e8b9 master#14667(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #14668 |
Baseline #14667 |
|
|---|---|---|
 Initial JS |
40.74MiB(~+0.01%) |
40.74MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
17.97% |
17.95% |
| Chunks |
21 |
21 |
| Assets |
23 |
23 |
| Modules |
4113 |
4113 |
| Duplicate Modules |
213 |
213 |
| Duplicate Code |
27.41% |
27.41% |
| Packages |
475 |
475 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #14668 |
Baseline #14667 |
|
|---|---|---|
| JS |
57.73MiB (~+0.01%) |
57.73MiB |
| HTML |
7.37KiB (-0.25%) |
7.39KiB |
Bundle analysis report Branch fix/grid-placement-below-layout Project dashboard
Generated by RelativeCI Documentation Report issue
balazsbajorics
approved these changes
Oct 9, 2024
seanparsons
approved these changes
Oct 9, 2024
gbalint
approved these changes
Oct 9, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
…r grid/flex children (#6502) **Problem:** 1. The grid placement subsection should be just below the layout section, since they are all related to the positioning of the selected element 2. Grid and Flex children should use the `[align|justify]Self` icons for the alignment buttons instead of the non-self ones. **Fix:** Do that. | Before | After | |---------|--------------| | <img width="276" alt="Screenshot 2024-10-09 at 11 48 24" src="https://github.com/user-attachments/assets/384dd748-17c6-4553-9d38-11b6c9dd1c8f"> |<img width="276" alt="Screenshot 2024-10-09 at 11 48 06" src="https://github.com/user-attachments/assets/31a3beb2-5201-4980-b9aa-1e19382d53eb"> | Fixes #6501
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
[align|justify]Selficons for the alignment buttons instead of the non-self ones.Fix:
Do that.
Fixes #6501