Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grid rearrange bugs #6509

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Fix grid rearrange bugs #6509

merged 3 commits into from
Oct 10, 2024

Conversation

gbalint
Copy link
Contributor

@gbalint gbalint commented Oct 9, 2024

Problem:
This PR fixes 2 issues:

  1. it is possible to drag a multicell child further to top/left and then it collapses
  2. dragging a multicell child to top/left corner collapses it to the single top/left cell
  3. width and height mismatch caused weird resize in multicell elements without explicit row or column setting.

Fix:

  1. Restrict the target row/column to >0 numbers
  2. Make sure multicell children are not reordered, but rearranged, because reorder deletes all explicit column/row properties
  3. fix the crazy mistype in the code

and add tests!

Manual Tests:
I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Play mode

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Try me

Copy link

relativeci bot commented Oct 9, 2024

#14683 Bundle Size — 57.93MiB (~+0.01%).

f766940(current) vs 916e8b9 master#14679(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#14683
     Baseline
#14679
Regression  Initial JS 40.93MiB(~+0.01%) 40.93MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 17.93% 0%
No change  Chunks 21 21
No change  Assets 23 23
No change  Modules 4142 4142
No change  Duplicate Modules 213 213
No change  Duplicate Code 27.32% 27.32%
No change  Packages 477 477
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#14683
     Baseline
#14679
Regression  JS 57.92MiB (~+0.01%) 57.92MiB
Improvement  HTML 7.37KiB (-0.25%) 7.39KiB

Bundle analysis reportBranch fix/grid-rearrangeProject dashboard


Generated by RelativeCIDocumentationReport issue

@gbalint gbalint marked this pull request as ready for review October 9, 2024 16:29
@gbalint gbalint merged commit a844aad into master Oct 10, 2024
16 checks passed
@gbalint gbalint deleted the fix/grid-rearrange branch October 10, 2024 08:58
liady pushed a commit that referenced this pull request Dec 13, 2024
**Problem:**
This PR fixes 2 issues:
1. it is possible to drag a multicell child further to top/left and then
it collapses
2. dragging a multicell child to top/left corner collapses it to the
single top/left cell
3. width and height mismatch caused weird resize in multicell elements
without explicit row or column setting.

**Fix:**
1. Restrict the target row/column to >0 numbers
2. Make sure multicell children are not reordered, but rearranged,
because reorder deletes all explicit column/row properties
3. fix the crazy mistype in the code

and add tests!

**Manual Tests:**
I hereby swear that:

- [x] I opened a hydrogen project and it loaded
- [x] I could navigate to various routes in Play mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants