Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include explicit Python dependencies #7

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

cofinoa
Copy link
Contributor

@cofinoa cofinoa commented Jan 9, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@cofinoa cofinoa requested a review from a team as a code owner January 9, 2024 16:55
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@cofinoa cofinoa merged commit 1bea521 into conda-forge:main Jan 9, 2024
7 checks passed
@mfansler
Copy link
Member

mfansler commented Jan 9, 2024

This seems misguided. R packages that need to run Python should use reticulate to establish dedicated (isolated) environments for the Python software they need. It almost never makes sense to have coinstallation of R and Python in the same environment. I would urge the changes here be reconsidered.

@cofinoa cofinoa deleted the py-deps-explicit branch January 9, 2024 21:43
@cofinoa
Copy link
Contributor Author

cofinoa commented Jan 9, 2024

@mfansler you are probably right.

IMO, this needs to be considered at R package level, where packages should be installed/deployed on demand.

This build is a hotfix for missing python, and its dependencies, needed by the R original package and raised (see
SantanderMetGroup/climate4R#61) which just assume that python and its dependencies are already available.

A dedicated environment (i.e. r-reticulate) is being used by default, but it's not required (see Python Version Configuration)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants