Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support variants.yml #27750

Open
Tracked by #2308
isuruf opened this issue Oct 2, 2024 · 7 comments
Open
Tracked by #2308

Support variants.yml #27750

isuruf opened this issue Oct 2, 2024 · 7 comments
Labels

Comments

@isuruf
Copy link
Member

isuruf commented Oct 2, 2024

Bug:

Currently only conda_build_config.yaml is supported in https://github.com/conda-forge/staged-recipes/blob/main/.ci_support/build_all.py#L111

cc @wolfv

@isuruf isuruf added the bug label Oct 2, 2024
@isuruf isuruf changed the title Support vairants.yml Support variants.yml Oct 2, 2024
@wolfv
Copy link
Member

wolfv commented Oct 2, 2024

Good point, will take a look.

@beckermr
Copy link
Member

beckermr commented Oct 2, 2024

I'm confused. If we allow folks to use a variants.yaml instead of a conda build config, we're going to break smithy, the bot, and likely other things. Am I missing something?

@beckermr
Copy link
Member

beckermr commented Oct 2, 2024

I've mentioned this before but I'll say it more explicitly. IMHO we want a drop-in replacement for conda-build that uses the new recipe format. We don't want to have to maintain two parallel tracks of infrastructure outside of the recipe itself.

@isuruf
Copy link
Member Author

isuruf commented Oct 2, 2024

Isn't variants.yaml the new conda_build_config.yaml for recipe-v1?

@beckermr
Copy link
Member

beckermr commented Oct 2, 2024

Idk but right now we use conda build to produce all of the ci support files when rendering with smithy. If we move to variants.yaml, we'll have to retool all of that at minimum.

@wolfv
Copy link
Member

wolfv commented Oct 7, 2024

I think Nichita has done the work already, and variants.yaml will automatically be parsed by rattler-build when rendering for variant discovery.

@wolfv
Copy link
Member

wolfv commented Oct 7, 2024

But we need to validate and make sure that this is what we want. I think supporting the old style conda_build_config.yaml is also doable (or even already works today thanks to smithy).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants
@wolfv @isuruf @beckermr and others