Mark ElizaService.Say idempotent (#126)

Say is free of side effects and perfectly safe to cache, so we should mark it idempotent. This also lets us demo HTTP GETs.
connectrpc · Aug 20, 2023 · b68eb35 · b68eb35
1 parent e8c89a0
commit b68eb35
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 33 deletions.
diff --git a/internal/gen/connectrpc/eliza/v1/eliza.pb.go b/internal/gen/connectrpc/eliza/v1/eliza.pb.go
diff --git a/internal/gen/connectrpc/eliza/v1/elizav1connect/eliza.connect.go b/internal/gen/connectrpc/eliza/v1/elizav1connect/eliza.connect.go
diff --git a/proto/connectrpc/eliza/v1/eliza.proto b/proto/connectrpc/eliza/v1/eliza.proto
@@ -24,7 +24,9 @@ package connectrpc.eliza.v1;
 // distributions.
 service ElizaService {
   // Say is a unary RPC. Eliza responds to the prompt with a single sentence.
-  rpc Say(SayRequest) returns (SayResponse) {}
+  rpc Say(SayRequest) returns (SayResponse) {
+    option idempotency_level = NO_SIDE_EFFECTS;
+  }
   // Converse is a bidirectional RPC. The caller may exchange multiple
   // back-and-forth messages with Eliza over a long-lived connection. Eliza
   // responds to each ConverseRequest with a ConverseResponse.