From cb26f2d09ab79770e23695d5d585109b75e02485 Mon Sep 17 00:00:00 2001 From: Ben Swartzlander Date: Sat, 5 Jun 2021 13:28:52 -0400 Subject: [PATCH] Address spelling/grammar errors --- csi.proto | 6 +++--- lib/go/csi/csi.pb.go | 6 +++--- spec.md | 14 +++++++------- 3 files changed, 13 insertions(+), 13 deletions(-) diff --git a/csi.proto b/csi.proto index e8a53b7b..ea455a6f 100644 --- a/csi.proto +++ b/csi.proto @@ -764,7 +764,7 @@ message ControllerUnpublishVolumeRequest { // section on how to use this field. map secrets = 3 [(csi_secret) = true]; - // Indicates SP MUST make the volume inacessible to the node or nodes + // Indicates SP MUST make the volume inaccessible to the node or nodes // it is being unpublished from. Any attempt to read or write data // to a volume from a node that has been fenced MUST NOT succeed, // even if the volume remains staged and/or published on the node. @@ -1505,8 +1505,8 @@ message NodeServiceCapability { // Note that, for alpha, `VolumeCondition` is intended to be // informative for humans only, not for automation. VOLUME_CONDITION = 4 [(alpha_enum_value) = true]; - // Indicates that the node supports the NodeUnpublishVolume.force - // field. Also indicates that the node supports the + // Indicates that the Node Plugin supports the NodeUnpublishVolume.force + // field. Also indicates that the Node Plugin supports the // NodeUnstageVolume.force field if it also has the // STAGE_UNSTAGE_VOLUME capability. FORCE_UNPUBLISH = 5 [(alpha_enum_value) = true]; diff --git a/lib/go/csi/csi.pb.go b/lib/go/csi/csi.pb.go index 1754d210..65193ab4 100644 --- a/lib/go/csi/csi.pb.go +++ b/lib/go/csi/csi.pb.go @@ -319,8 +319,8 @@ const ( // Note that, for alpha, `VolumeCondition` is intended to be // informative for humans only, not for automation. NodeServiceCapability_RPC_VOLUME_CONDITION NodeServiceCapability_RPC_Type = 4 - // Indicates that the node supports the NodeUnpublishVolume.force - // field. Also indicates that the node supports the + // Indicates that the Node Plugin supports the NodeUnpublishVolume.force + // field. Also indicates that the Node Plugin supports the // NodeUnstageVolume.force field if it also has the // STAGE_UNSTAGE_VOLUME capability. NodeServiceCapability_RPC_FORCE_UNPUBLISH NodeServiceCapability_RPC_Type = 5 @@ -2021,7 +2021,7 @@ type ControllerUnpublishVolumeRequest struct { // This field is OPTIONAL. Refer to the `Secrets Requirements` // section on how to use this field. Secrets map[string]string `protobuf:"bytes,3,rep,name=secrets,proto3" json:"secrets,omitempty" protobuf_key:"bytes,1,opt,name=key,proto3" protobuf_val:"bytes,2,opt,name=value,proto3"` - // Indicates SP MUST make the volume inacessible to the node or nodes + // Indicates SP MUST make the volume inaccessible to the node or nodes // it is being unpublished from. Any attempt to read or write data // to a volume from a node that has been fenced MUST NOT succeed, // even if the volume remains staged and/or published on the node. diff --git a/spec.md b/spec.md index e727923b..f448ab79 100644 --- a/spec.md +++ b/spec.md @@ -1338,7 +1338,7 @@ message ControllerUnpublishVolumeRequest { // section on how to use this field. map secrets = 3 [(csi_secret) = true]; - // Indicates SP MUST make the volume inacessible to the node or nodes + // Indicates SP MUST make the volume inaccessible to the node or nodes // it is being unpublished from. Any attempt to read or write data // to a volume from a node that has been fenced MUST NOT succeed, // even if the volume remains staged and/or published on the node. @@ -2195,8 +2195,8 @@ If the corresponding Controller Plugin has `PUBLISH_UNPUBLISH_VOLUME` controller The CO MUST guarantee that this RPC is called after all `NodeUnpublishVolume` have been called and returned success for the given volume on the given node. If the Node Plugin has the `FORCE_UNPUBLISH` capability, the CO MAY specify `force` as `true` in which case the Node Plugin MUST support unstaging volumes even when access has been revoked with `ControllerUnpublishVolume`. -Because data loss is inevitable in such circumstances, the `force` flag is an indication that success is desired even it if means losing data. -It is essential that after a successful call to `NodeUnstageVolume` that there be no buffered data on the node related to the volume which might result in unintetional modification of the volume if it were to be subsequently re-staged to that node. +Because data loss is inevitable in such circumstances, the `force` flag is an indication that success is desired even if it means losing data. +It is essential that after a successful call to `NodeUnstageVolume` that there will be no buffered data on the node related to the volume which might result in unintentional modification of the volume if it was to be subsequently re-staged to that node. The Plugin SHALL assume that this RPC will be executed on the node where the volume is being used. @@ -2368,8 +2368,8 @@ If the corresponding Controller Plugin has `PUBLISH_UNPUBLISH_VOLUME` controller The Plugin SHALL assume that this RPC will be executed on the node where the volume is being used. If the Node Plugin has the `FORCE_UNPUBLISH` capability, the CO MAY specify `force` as `true` in which case the Node Plugin MUST support unpublishing volumes even when access has been revoked with `ControllerUnpublishVolume`. -Because data loss is inevitable in such circumstances, the `force` flag is an indication that success is desired even it if means losing data. -It is essential that after a successful call to `NodeUnpublishVolume` that there be no buffered data on the node related to the volume which might result in unintetional modification of the volume if it were to be subsequently re-published to that node. +Because data loss is inevitable in such circumstances, the `force` flag is an indication that success is desired even if it means losing data. +It is essential that after a successful call to `NodeUnpublishVolume` that there will be no buffered data on the node related to the volume which might result in unintetional modification of the volume if it was to be subsequently re-published to that node. This RPC is typically called by the CO when the workload using the volume is being moved to a different node, or all the workload using the volume on a node has finished. @@ -2553,8 +2553,8 @@ message NodeServiceCapability { // Note that, for alpha, `VolumeCondition` is intended to be // informative for humans only, not for automation. VOLUME_CONDITION = 4 [(alpha_enum_value) = true]; - // Indicates that the node supports the NodeUnpublishVolume.force - // field. Also indicates that the node supports the + // Indicates that the Node Plugin supports the NodeUnpublishVolume.force + // field. Also indicates that the Node Plugin supports the // NodeUnstageVolume.force field if it also has the // STAGE_UNSTAGE_VOLUME capability. FORCE_UNPUBLISH = 5 [(alpha_enum_value) = true];