Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track Additional Comments for the RPC Interactions of VolumeSnapshot and GroupVolumeSnapshot #554

Open
carlory opened this issue Oct 13, 2023 · 0 comments

Comments

@carlory
Copy link

carlory commented Oct 13, 2023

Is your feature request related to a problem?/Why is this needed

If the implementation of the SP's group snapshot function is flawed, for example, if two data volumes are snapshotted at the same time, one will succeed and the other will always fail, then no matter how many times CO retries the call, it will not get the expected results. It maybe lead to a deadlock in CO. But in the spec, I can't find a suitable status code to tell CO not to retry.

Describe the solution you'd like in detail

As @bswartz said,

The only other solution I can see is to return a "successful" snapshot but mark it as broken or partial with some explicit boolean
value in the response message. This would allow the CO to stop retying and then decide whether to keep the broken group snapshot or clean it up the normal way.

Additional context

See #545 (comment) and #545 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant