New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exit_sendmail plugin always fails to find koji build ID for scratch builds #1591

Open

ktdreyer opened this issue Feb 23, 2021 · 1 comment

Labels

Contributor

ktdreyer commented Feb 23, 2021

scratch builds always hit this code path in atomic_reactor/plugins/exit_sendmail.py:

self.koji_build_id = self.workflow.exit_results.get(KojiImportPlugin.key)
if not self.koji_build_id:
    self.log.info("Failed to fetch koji build ID")

If it's a scratch build, we do not need to try to look up a Koji build ID.

The text was updated successfully, but these errors were encountered:

lcarva added the help wanted label

Contributor Author

ktdreyer commented Nov 17, 2021

What if we just deleted this plugin entirely: #1710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment