-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support depends_on type service_completed_successfully #575
Comments
It seems like |
Actually, i think podman waits for the healthiness anyway, so anything one specifies behaves like |
Last time i checked it podman was not executing any healthchecks, it was only waiting for services to be started. That's a huge difference. |
I'm on the following versions and can confirm that service_healthy condition seems to be ignored and treated as service_started. |
any status update on this feature? any way to workaround this? |
@kontsaki Have a look at #453, which has a preliminary implementation of TL;DR (maybe inaccurate!):
So, it is sad to say that there is still no good way to support it. I ended up having the container exit immediately when it fails to connect to the dependency container, and set |
I ended up using docker-compose provided by https://github.com/docker/compose and it works as expected with podman as the backend. I have also installed the compat package podman-docker on Fedora, not sure if this makes podman run as daemon but currently everything works with rootless podman and all docker-compose features. |
@mbergen, @mdellweg, @Greenall I just filed a dedicated issue for the problem with the |
Is your feature request related to a problem? Please describe.
The problem is that podman-compose is incompatible with current docker-compose.yml because it does not support
service_completed_successfully
.According to the compose spec
condition
: condition under which dependency is considered satisfiedservice_started
: is an equivalent of the short syntax described aboveservice_healthy
: specifies that a dependency is expected to be "healthy"(as indicated by healthcheck) before starting a dependent
service.
service_completed_successfully
: specifies that a dependency is expected to runto successful completion before starting a dependent service.
Describe the solution you'd like
podman-compose implements
service_completed_successfully
as per the spec.Describe alternatives you've considered
None
Additional context
I didn't check if the other conditions are supported yet, but they should also be.
The text was updated successfully, but these errors were encountered: