Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar toggle issues #10

Open
mmacfadden opened this issue Jan 10, 2020 · 2 comments
Open

Sidebar toggle issues #10

mmacfadden opened this issue Jan 10, 2020 · 2 comments
Assignees
Labels

Comments

@mmacfadden
Copy link
Contributor

The side bar toggle will scroll off the screen. And when it does it goes OVER the title bar:

sidebar-toggle

We should have the side bar toggle be fixed in the middel (vertically) of the screen.

@alalonde
Copy link
Contributor

Just pushed a fix for the z-index issue.

Also, notice in the screenshot how the header for the chat example looks different than for any other example. That was fixed in e5eda3c.

If we want the sidebar toggle to be position: fixed, we should make the whole sidebar fixed as well.

@mmacfadden
Copy link
Contributor Author

@alalonde yes.. I had not pulled the latest yet.

What would making the whole sidebar fixed mean? Would have have to have is scroll inside its container? If so, I am not sure that would be intuitive to users The main problem is that you can easily scroll the toggle off the screen and not be able to find it. It seems natural to just have it centered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants