Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime type check for cache configuration #220

Open
yuit opened this issue Nov 2, 2017 · 1 comment
Open

Runtime type check for cache configuration #220

yuit opened this issue Nov 2, 2017 · 1 comment

Comments

@yuit
Copy link
Contributor

yuit commented Nov 2, 2017

With TypeScript, type checker helps catching lots of mistake. However, when using using Hermes in JS codebase, I think it will be valuable to provide some runtime check for correct type for cache config.

One possible option to do so (https://github.com/rbuckton/reflect-metadata)

@nevir
Copy link
Contributor

nevir commented Nov 2, 2017

I think we should start with explicit checks on the public surface area - the downside of reflect-metadata is that it only exposes the raw JS types (like Object, or Function, but nothing more nuanced than that)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants