Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIP-96 Upload Auth header has an invalid payload tag #391

Open
Ademan opened this issue Jul 22, 2024 · 0 comments
Open

NIP-96 Upload Auth header has an invalid payload tag #391

Ademan opened this issue Jul 22, 2024 · 0 comments

Comments

@Ademan
Copy link

Ademan commented Jul 22, 2024

If you inspect the Auth header coracle sends for NIP-96 uploads, you'll see that the payload tag does not change for different files. It is always 44136fa355b3678a1146ad16f7e8649e94fb4fc21fe77e8310c060f61caaff8a (which happens to be sha256("{}"))

This is because the body passed to nip98Fetch() in commands.ts is a FormData which stringifies to "{}"

Evidently, nostr.build (and other?) NIP-96 servers are not checking the payload tag, because this doesn't appear to cause an issue.

Furthermore, what the payload tag should actually be, appears ambiguous (to me).

See nostr-protocol/nips#1376 for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant