-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bufsize default value should be 1232 #295
Comments
The correct behaviour were fixed by coredns/coredns#5368, but the documentation is still misleading. Especially examples with value 512 should have never be presented. |
Can you open a pr that adjusts the documentation? |
Hmm, on the second glance, I am not sure it works described way anymore. It can change EDNS0 size only if it were already present in query. But it cannot add EDNS header into forwarded packet if it were not there already. It can also only reduce received value further, never increase it. |
Mention also increasing request size is not possible, it can only reduce the accepted size. Resolves coredns#295 Signed-off-by: Petr Menšík <pemensik@redhat.com>
According to http://www.dnsflagday.net/2020/, the default value for incoming requests should be 1232. It is experimentally chosen good default value, unless the administrator knows better value.
Current examples are confusing and misleading. If the incoming request did not contain OPT record, that means EDNS0 header, then the server must not send the answer larger than 512 bytes. It may not solve it by adding EDNS0 header to response.
The text was updated successfully, but these errors were encountered: