Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for "isolated test" flag #3

Open
dune73 opened this issue Nov 10, 2023 · 0 comments
Open

Support for "isolated test" flag #3

dune73 opened this issue Nov 10, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@dune73
Copy link
Member

dune73 commented Nov 10, 2023

Definition "isolated test"

An "isolated test" is a test that triggers only the corresponding rule on the paranoia level of the rule and lower paranoia levels.

This means that an isolated test for a rule on PL1 may only trigger the corresponding rule on PL1, but it may also trigger rules on PL2 and higher.

Reasoning

The CRS Status Page depends on isolated tests. Carrying a separate list of isolated tests will lead to redundancy and an outdated list. So the information whether a test is isolated or not, should be kept together with the test.

Implementation

The information is meant to be with the test, next to the description.

Implementation variant 1: New flag next to description

  - test_title: 942100-1
    desc: "Simple SQL Injection"
    isolated: true
    stages:
      - stage:

Implementation variant 2: Create metadata array next to description, add flag to new metadata collection

  - test_title: 942100-1
    desc: "Simple SQL Injection"
    metadata:
      - isolated: true
    stages:
      - stage:

Implementation variant 3: Create metadata array, move description into new metadata collection, add flag to new metadata collection

 - test_title: 942100-1
   metadata:
     - desc: "Simple SQL Injection"
     - isolated: true
   stages:
     - stage:

CAVEAT

For the CI of the rule set it is important to make sure the tests flagged as isolated are really isolated, also when we edit rules. See definition above.

@fzipi fzipi added the enhancement New feature or request label Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants