Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A question about function getUVError in mapper.py #27

Open
Emil-Jiang opened this issue Apr 22, 2024 · 1 comment
Open

A question about function getUVError in mapper.py #27

Emil-Jiang opened this issue Apr 22, 2024 · 1 comment

Comments

@Emil-Jiang
Copy link

Emil-Jiang commented Apr 22, 2024

Congradulation for such an achievement!

The paper defines the covariance matrix for measurement error is

$$ \mathbf{R}_k^{uv}=\begin{bmatrix}(\sigma_mw_k)^2&0 \\ 0&(\sigma_mh_k)^2 \end{bmatrix} $$

but in the code getUVError, it is

def getUVError(box):
    u = 0.05*box[3]
    v = 0.05*box[3]
    if u>13:
        u = 13
    elif u<2:
        u = 2
    if v>10:
        v = 10
    elif v<2:
        v = 2
    return u,v

while box[3] is the height of the bounding box, should here be u=0.05*box[2]?

@corfyi
Copy link
Owner

corfyi commented Apr 24, 2024

yes, you are right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants