Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not place the signature within coordinates #105

Open
gentios opened this issue May 16, 2020 · 3 comments
Open

Does not place the signature within coordinates #105

gentios opened this issue May 16, 2020 · 3 comments

Comments

@gentios
Copy link
Contributor

gentios commented May 16, 2020

hi Cory, I hope you are well you and your family in these days of pandemic Covid-19.

I don't know if you are still maintaining the NoPoDoFo library, I was working today with NoPoDoFo and the library doesn't sign properly the pdf documents generated from Puppeteer ( HTML -> PDF )

2020-05-14

the image is very small its backwards rotated and it's not within coordinates that I am passing for rect.left and rect.bottom

@corymickelson
Copy link
Owner

this is interesting, can you provide some more details on the generated document: the version number, creator (is it actually puppeteer or are they using something else under the hood), or could you attach an example doc. I've not been able to give this library the attention I would like to. I will absolutely look into this, but it may take me longer than usual.
Take care

@gentios
Copy link
Contributor Author

gentios commented May 22, 2020

hi @corymickelson, thank you for the support.

From this one I think that the nopodofo.Painter could be the problem since it's the only function that paints (writes) the image in the document: https://github.com/corymickelson/NoPoDoFo/blob/master/spec/unit/Signer.ts#L129

https://github.com/corymickelson/NoPoDoFo/blob/master/src/doc/Painter.cc#L288 )

Since the SignatureField is placed correctly and within coordinates and the document is properly digitally signed.

I am also attaching a PDF sample generated from puppeteer
c0af1ddb-cb5a-4a13-8f42-4bbe2cd97694.pdf

Thanks and take care

@gentios
Copy link
Contributor Author

gentios commented Jun 19, 2020

Just to give an update, the bug happens also when PDF files are also generated/exported from docs.google.com.

@corymickelson any update on this bug ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants