Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crosscheck of External Compton radiation #18

Closed
2 of 3 tasks
cosimoNigro opened this issue May 14, 2020 · 3 comments
Closed
2 of 3 tasks

Crosscheck of External Compton radiation #18

cosimoNigro opened this issue May 14, 2020 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@cosimoNigro
Copy link
Owner

cosimoNigro commented May 14, 2020

We should try to crosscheck with different approaches the External Compton radiation:

  • crosscheck against the literature;
  • crosscheck against another code;
  • crosscheck against back-of-the-envelope calculation.

Each of the tick box will be marked once the crosscheck is obtained.
After all of them are marked we will close the issue, and be sure that the EC computation is reliable.

@cosimoNigro cosimoNigro added the enhancement New feature or request label May 14, 2020
@cosimoNigro cosimoNigro added this to the EC crosscheck milestone May 14, 2020
@cosimoNigro
Copy link
Owner Author

As for the crosscheck against the literature this is done in the tutorials.
https://agnpy.readthedocs.io/en/latest/tutorials/external_compton.html
@jsitarek though pointed out that he cannot reproduce results in some old MAGIC publications
https://github.com/cosimoNigro/agnpy/blob/master/tests/crosschecks/ec_js.ipynb
we have to check this before marking the tick box.

@cosimoNigro
Copy link
Owner Author

cosimoNigro commented May 14, 2020

crosscheck against back-of-the-envelope calculation where started by @jsitarek in
https://github.com/cosimoNigro/agnpy/blob/master/tests/basic/simple_ec.ipynb
and commented in Issues #12 and #13.

@cosimoNigro
Copy link
Owner Author

cosimoNigro commented Oct 7, 2020

I think the introduction of the test suite addresses the pending checks in this issue.
We have now the following automatic crosschecks for the external Compton radiation:
- crosscheck for EC on Disk against the literature (Finke 2016)
ec_disk_comparison_figure_8_finke_2016
- crosscheck for EC on Broad Line Region against the literature (Finke 2016)
ec_blr_comparison_figure_10_finke_2016
- crosscheck for EC on Dust Torus against the literature (Finke 2016)
ec_dt_comparison_figure_11_finke_2016

As for the crosschecks against back-of-the-envelope calculation I have implemented two test functions that check, in the limit of large distances, if the EC on the BLR (or DT) tends to the one of a point-like source approximating them.

The crosschecks against another code are a bit difficult since Jetset uses different geometries for the targets.
Nonetheless I am confident the External Compton calculations in agnpy are reliable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant