Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile_proto_services() overwrites the compile_protos() work #34

Open
ancazamfir opened this issue Jan 5, 2021 · 0 comments
Open

compile_proto_services() overwrites the compile_protos() work #34

ancazamfir opened this issue Jan 5, 2021 · 0 comments

Comments

@ancazamfir
Copy link

We had this issue also in ibc-rs when trying to compile some IBC core services.
For example, with this addition:

diff --git a/proto-build/src/main.rs b/proto-build/src/main.rs
index 9d9591c..aeeb30d 100644
--- a/proto-build/src/main.rs
+++ b/proto-build/src/main.rs
@@ -161,6 +161,7 @@ fn compile_proto_services(out_dir: impl AsRef<Path>) {
         sdk_dir.join("proto/cosmos/bank/v1beta1/query.proto"),
         sdk_dir.join("proto/cosmos/tx/v1beta1/service.proto"),
         sdk_dir.join("proto/cosmos/tx/v1beta1/tx.proto"),
+        sdk_dir.join("proto/ibc/core/channel/v1/query.proto"),
     ];

     // List available paths for dependencies

and after cargo run some of the structures are missing from ../cosmos-sdk-proto/src/prost/ibc.core.channel.v1.rs (all Msg.. structs, GenesisState).
In ibc-rs we fixed this by doing the proto and service compilation with tonic see here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant