Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ABI encoding in ICS20Transfer (solidity) #116

Open
gjermundgaraba opened this issue Nov 22, 2024 · 0 comments · May be fixed by #117
Open

Use ABI encoding in ICS20Transfer (solidity) #116

gjermundgaraba opened this issue Nov 22, 2024 · 0 comments · May be fixed by #117
Assignees
@gjermundgaraba

Comments

@gjermundgaraba
Copy link
Contributor

gjermundgaraba commented Nov 22, 2024 •
edited
Loading

Given the results of #95, we have decided to implement ABI encoding for ICS20 transfer.

This task is dependent on cosmos/ibc-go#7591

Definition of done:

  • Change the payload structure in ICS20Transfer from JSON to ABI encoding.
  • Update e2e tests with ABI encoding and communication with ibc-go (see dependent task above)
  • Remove all JSON-related code
  • Update benchmarks
@gjermundgaraba gjermundgaraba converted this from a draft issue Nov 22, 2024
This was referenced Nov 22, 2024
Closed
Closed
@gjermundgaraba gjermundgaraba changed the title Add support for ABI encoding in ICS20Transfer (solidity) Use ABI encoding in ICS20Transfer (solidity) Nov 22, 2024
@gjermundgaraba gjermundgaraba self-assigned this Nov 22, 2024
@gjermundgaraba gjermundgaraba linked a pull request Nov 24, 2024 that will close this issue
feat: use abi encoding of ICS20Transfer payload #117
Open
6 tasks
@gjermundgaraba gjermundgaraba linked a pull request Nov 24, 2024 that will close this issue
Open
6 tasks
@gjermundgaraba gjermundgaraba moved this from In progress to In review in IBC-GO Eureka Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gjermundgaraba gjermundgaraba

Labels
None yet
Projects
IBC-GO Eureka
Status: In review
Milestone
No milestone
1 participant
@gjermundgaraba