Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove random seed initializer #14

Open
tleyden opened this issue Jan 22, 2018 · 0 comments
Open

Remove random seed initializer #14

tleyden opened this issue Jan 22, 2018 · 0 comments

Comments

@tleyden
Copy link
Contributor

tleyden commented Jan 22, 2018

I just stumbled upon https://github.com/couchbase/cbgt/blob/master/misc.go#L32

func init() {
	rand.Seed(time.Now().UTC().UnixNano())
}

from the git history it looks like I had added it at some point.

I think it might have been accidentally pushed as a temporary workaround for https://issues.couchbase.com/browse/MB-24237?focusedCommentId=214133, and it should probably get removed per @mschoch's comment about libraries not touching the global random seed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tleyden