-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove expect and unwrap from codebase #255
Comments
expect and unwrap in main.rs are probably ok, these happen at startup. unwrap when taking a lock also ok, this can only happen if the lock has been poisoned, i.e. a panic occurred in another thread which has holding the lock - this a) shouldn't be happening and b) is probably unrecoverable. |
@chvck What about the numerous |
If we're going to fail something we should do it gracefully and at least attempt to give the user some information about why we've failed. We shouldn't just panic.
The text was updated successfully, but these errors were encountered: