Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create prepared statement examples #3

Open
ToddGreenstein opened this issue Dec 2, 2015 · 3 comments
Open

Create prepared statement examples #3

ToddGreenstein opened this issue Dec 2, 2015 · 3 comments

Comments

@ToddGreenstein
Copy link

Simon has started on this for Java, we will follow the example for all of the sdk's

@simonbasle
Copy link
Contributor

pinging @couchbaselabs/sdk-team so that people follow this 👀

@mnunberg
Copy link
Contributor

mnunberg commented Dec 2, 2015

While I support this in theory, I don't know if we shouldn't just merge the 'prepared statement' example in the normal query placeholder example, or place the prepared stuff in comments, like so:

q = N1QLQuery(...)
# Uncomment the next line to make this a 'prepared' query
# q.adhoc = False

Rather than repeating an almost identical example just for one single flag. Since there is absolutely no user-facing different (other than a simple flag, and hopefully increased performance..)

simonbasle added a commit that referenced this issue Dec 2, 2015
@simonbasle
Copy link
Contributor

ah didn't see Mark's remarks 😦, maybe I should have done a pull-request

simonbasle added a commit that referenced this issue Dec 2, 2015
@ToddGreenstein ToddGreenstein self-assigned this Dec 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants