-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy to tenderly #35
Conversation
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I'll submit a PR on the env vars to isolate those that are for the forge scripts.
This reverts commit a6a8f4e.
bf8fbb0
to
0e53f04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just the minor typo nit.
The main motivation of this PR is to deploy to our tenderly account the WatchTower.
However, during the deployment, I had to do some minor changes due to some issues I observed. Sorry for a MISC PR, but just to make it easier I documented in the description the changes and also did some code annotations giving more context (see review mode).
How to deploy this?
Since I didn't know much about this service, I created some documentation that I hope is handy for ONCALL and mantainers of this project.
It shows how to deploy, gives context of what it does. It Explains and gives pointers for all the related concepts you need to know to understand this project, so anyone can get up to speed.
Additionally this document will point out about the evolution (replacement by a distributed version)
https://www.notion.so/cownation/WatchTower-legacy-Tenderly-Composable-CoW-Indexer-8e62049feb6e440d9b097f83e054ac75?pvs=4
Local test for Tenderly Web3 Actions
To debug some issues I had to run Tenderly Actions locally to shorten the dev cycle.
.env
file, so I added dotenv lib. I think it was working for the CLI but notfor the github actions.Allow basic Auth in the EthersJS provider
Some RPC nodes require basic auth, so i had to add it.
Allow basic Auth in the EthersJS provider
Now we support to add optionally a user and password for each
Reduce logs
I removed a bunch of logs, so we would write in the log only when there's relevant changes.
For example, we don't write any more "processing block XXX", but we log if we detect a new order, post to the API, etc.
Actually the logs were breaking the indexing (circular JSON dependency), see:
Also, it was making Tenderly to remove all logs and show you nothing:
Improve log messages
The issue above was a bit hard to debug cause i was not sure which log was causing this. This PR in general adds some more context on where things fail, and give you some nice outputs of requests, API responses, etc:
Not included
I still want to reiterate in other PRs to: