Do not fail on intermediate errors, but fail at the end if there was … #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to address some concerns around errors.
Hiden errors
Right now, if there's an error processing some logs, or posting the order, Tenderly will still show you that it succeeded.
This is because we catch and handle the errors, so you need to get inside each execution and check the logs in order to see if something is wrong.
Change applied
This PR will still log every issue, and continue processing until the end, but if there was at least one error, we will throw it at the end of the execution so Tenderly knows that something went badly.
BEFORE:
AFTER
This will make it easier to spot the executions that failed
Not included
Some of these errors could be handled, and shouldn't throw, for example, DuplicatedOrder should be a warning, and not an error (the order is in the system):
For now, this PR just want to add more visibility when an error occurs.