Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fail on intermediate errors, but fail at the end if there was … #36

Merged
merged 5 commits into from
Aug 11, 2023

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Aug 8, 2023

This PR tries to address some concerns around errors.

Hiden errors

Right now, if there's an error processing some logs, or posting the order, Tenderly will still show you that it succeeded.

This is because we catch and handle the errors, so you need to get inside each execution and check the logs in order to see if something is wrong.

Change applied

This PR will still log every issue, and continue processing until the end, but if there was at least one error, we will throw it at the end of the execution so Tenderly knows that something went badly.

BEFORE:
image

AFTER
image

This will make it easier to spot the executions that failed

Not included

Some of these errors could be handled, and shouldn't throw, for example, DuplicatedOrder should be a warning, and not an error (the order is in the system):
image

For now, this PR just want to add more visibility when an error occurs.

@anxolin anxolin marked this pull request as draft August 8, 2023 11:05
@anxolin anxolin force-pushed the fail-if-error branch 3 times, most recently from 208c339 to f14aaca Compare August 11, 2023 10:28
@anxolin anxolin changed the base branch from deploy-to-tenderly to main August 11, 2023 10:29
@anxolin anxolin requested a review from mfw78 August 11, 2023 11:39
@anxolin anxolin marked this pull request as ready for review August 11, 2023 11:39
Copy link
Contributor

@mfw78 mfw78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@anxolin anxolin merged commit 2d340af into main Aug 11, 2023
2 checks passed
@mfw78 mfw78 deleted the fail-if-error branch August 12, 2023 00:19
@mfw78 mfw78 restored the fail-if-error branch August 12, 2023 06:03
@anxolin anxolin deleted the fail-if-error branch August 16, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants