Improve logs and dont fail if it is a duplicated order #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
anxolin
commented
Aug 14, 2023
mfw78
previously approved these changes
Aug 15, 2023
Co-authored-by: mfw78 <53399572+mfw78@users.noreply.github.com>
anxolin
force-pushed
the
dont-fail-if-duplicated-order
branch
from
949e145
to
aaf2d81
Compare
Co-authored-by: mfw78 <53399572+mfw78@users.noreply.github.com>
Co-authored-by: mfw78 <53399572+mfw78@users.noreply.github.com>
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR do a series of improvements to have better visibility on our indexing so we can:
Dont show as error when Duplicated Orders
When an order is duplicated means its already in the orderbook. Therefore, we shouldn't mark the indexing as an error. This PR shows a warning but continues. The order will be registered and monitored in the same way as if the registration in the order book was successful.
Notify errors in slack
This PR will notify any error in slack
Its not an ideal solution, but a patch until we have the Valory implementation in place
Show more context in the logs
Now logs show more context, like the ethereum transaction where the logs were found in the first place.
I found this is useful when debugging issues.
I made it so its part of the model, so now is persisted and logged.
Overengineered solution to fight some logging problems with Tenderkly logs
Tenderly logs have a limitation of 4K, if you reach it, they will disable them so you will miss a lot of important information.
This PR overrides the console.log so, in case you try to log something bigger (a big JSON) it will try to break the message into several logs.
The console log is overridden cause i suspected that one internal library was logging something big, and that was breaking Tendrly. This override helped a lot, and now the logs are more clear, however, i still see from time to time we reach the limitation for some reason I don't understand