Add sentry #43
Add sentry #43
Conversation
Did you mean: sentry? |
actions/utils.ts
Outdated
| const transaction = Sentry.startTransaction({ | ||
| op: "test", | ||
| name: "My First Test Transaction", | ||
| }); |
There was a problem hiding this comment.
Will this be removed before merging?
| @@ -127,15 +131,49 @@ async function getTradeableOrderWithSignature( | |||
| conditionalOrder: ConditionalOrder, | |||
| contract: ComposableCoW | |||
| ) { | |||
| const proof = conditionalOrder.proof ? conditionalOrder.proof.path : []; | |||
| const offchainInput = "0x"; | |||
| contract.getTradeableOrderWithSignature; | |||
| const { to, data } = | ||
| await contract.populateTransaction.getTradeableOrderWithSignature( | ||
| owner, | ||
| conditionalOrder.params, | ||
| offchainInput, | ||
| proof | ||
| ); | ||
|
|
||
| // await contract.provider | ||
| // .estimateGas({ | ||
| // to: contract.address, | ||
| // data, | ||
| // }) | ||
| // .then((r) => { | ||
| // console.log("[getTradeableOrderWithSignature:estimateGas] Success", r); | ||
| // }) | ||
| // .catch((e) => { | ||
| // console.error( | ||
| // '[getTradeableOrderWithSignature:estimateGas] Error during "getTradeableOrderWithSignature" call: ', | ||
| // e | ||
| // ); | ||
| // }); | ||
|
|
||
| console.log("[getTradeableOrderWithSignature] Simulate", { | ||
| to, | ||
| data, | ||
| }); |
There was a problem hiding this comment.
If the objective is to get the calldata so that it can be tested / simulated elsewhere, may I suggest using encodeFunctionData to produce the calldata that you desire for the simulation?
Actually, on second glance, populateTransaction does seem better. Is there any reason for keeping the estimateGas commented code though as this would return the same errors as just doing the callStatic, no?
There was a problem hiding this comment.
No, sorry, this was a test I did debug the issue yesterday. I should have removed it. Im doing a follow-up with some cleanup and a small refactor and I will kill this
| } from "@sentry/node"; | ||
| import { CaptureConsole as CaptureConsoleIntegration } from "@sentry/integrations"; | ||
|
|
||
| // const Sentry = require("@sentry/node"); |
There was a problem hiding this comment.
| // const Sentry = require("@sentry/node"); |
There was a problem hiding this comment.
I will delete in a follow up PR (small refactor)
| // await contract.provider | ||
| // .estimateGas({ | ||
| // to: contract.address, | ||
| // data, | ||
| // }) | ||
| // .then((r) => { | ||
| // console.log("[getTradeableOrderWithSignature:estimateGas] Success", r); | ||
| // }) | ||
| // .catch((e) => { | ||
| // console.error( | ||
| // '[getTradeableOrderWithSignature:estimateGas] Error during "getTradeableOrderWithSignature" call: ', | ||
| // e | ||
| // ); | ||
| // }); |
There was a problem hiding this comment.
| // await contract.provider | |
| // .estimateGas({ | |
| // to: contract.address, | |
| // data, | |
| // }) | |
| // .then((r) => { | |
| // console.log("[getTradeableOrderWithSignature:estimateGas] Success", r); | |
| // }) | |
| // .catch((e) => { | |
| // console.error( | |
| // '[getTradeableOrderWithSignature:estimateGas] Error during "getTradeableOrderWithSignature" call: ', | |
| // e | |
| // ); | |
| // }); |
There was a problem hiding this comment.
will delete in a follow up PR. This was useful for some test, but i can remove it now
|
The comments above not addressed in this PR is coming in a follow up today |
Summary
Tenderly Actions logs can't be trusted 100%, they currently have an issue which make us have some blind spots on what is happening.
for this reason i integrated the WatchTower with tenderly, so we can debug better cases we encounter in production:
Sentry project: https://cowprotocol.sentry.io/projects/watch-tower-tenderly/?project=4505714328928256
To Test