Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure codebase #47

Open
3 of 4 tasks
fhenneke opened this issue May 31, 2023 · 0 comments
Open
3 of 4 tasks

Restructure codebase #47

fhenneke opened this issue May 31, 2023 · 0 comments

Comments

@fhenneke
Copy link
Contributor

fhenneke commented May 31, 2023

We decided to restructure the code to make it easier to maintain and extend.

The general structure would be as follows:

  • Data collection via APIs which are encapsulated in classes, e.g., Web3API, OrderbookAPI
  • Data processing in tests; each test has its own class and depends on different APIs for fetching data
  • unit tests and end-to-end tests using mock instances for the data fetching

It might be possible to make those changes one by one, without breaking the code.

TODO:

  • implement prototype for iterating on the design
  • move all data fetching to API classes
  • convert all monitoring tests into new format
  • add unit tests and e2e tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant