Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If slippage is too high why not trade less? #2

Open
nlordell opened this issue Mar 31, 2022 · 0 comments
Open

If slippage is too high why not trade less? #2

nlordell opened this issue Mar 31, 2022 · 0 comments

Comments

@nlordell
Copy link
Contributor

I have encountered the silly situation where the trading bot will not trade because I gave it too many funds in the same token.

This happens because we have a maximum slippage tolerance. The bot checks this by comparing the price it gets when trading all of its balance in a token versus the price it would get if it traded only 1% of the balance. If the price in the full balance case is worse by too much it will not trade.

This feels wrong to me because it is likely that if the bot had fewer funds in the first place then the slippage wouldn't be a problem. The solution could be to trade low amounts by default instead of using the full balance.

Original issue gnosis/gp-v2-trading-bot#23 by @vkgnosis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant