Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

env_logger should not be a dependency of cozo-core #287

Open
jakoschiko opened this issue Nov 30, 2024 · 0 comments
Open

env_logger should not be a dependency of cozo-core #287

jakoschiko opened this issue Nov 30, 2024 · 0 comments

Comments

@jakoschiko
Copy link

Currently env_logger is a dependency of cozo-core. But it's only initialized in tests and the binary.

> rg env_logger
Cargo.lock
773: "env_logger",
832: "env_logger",
1272:name = "env_logger"

cozo-core/src/runtime/tests.rs
75:    let _ = env_logger::builder().is_test(true).try_init();
94:    let _ = env_logger::builder().is_test(true).try_init();
124:    let _ = env_logger::builder().is_test(true).try_init();

cozo-bin/src/main.rs
14:use env_logger::Env;
40:            env_logger::Builder::from_env(Env::default().default_filter_or("info")).init();

cozo-bin/Cargo.toml
47:env_logger = "0.11.3"

cozo-core/Cargo.toml
93:env_logger = "0.11.3"

cozo-core/tests/air_routes.rs
15:use env_logger::Env;
23:        env_logger::Builder::from_env(Env::default().default_filter_or("info")).init();

So I assume it could be a dev-dependency for cozo-core and a normal dependency for cozo-bin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant