Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py "extras" doesn't line up with documentation #15

Open
hosford42 opened this issue Jul 10, 2024 · 0 comments
Open

setup.py "extras" doesn't line up with documentation #15

hosford42 opened this issue Jul 10, 2024 · 0 comments

Comments

@hosford42
Copy link
Contributor

The installation instructions at the top of README.md suggest this installation command:

pip install "pycozo[embedded,requests,pandas]"

But when I run it on the command line, I get this warning:

C:\...\pycozo> pip install "pycozo[requests]"
WARNING: pycozo 0.7.6 does not provide the extra 'requests'

This is because setup.py names the extra client instead of requests:

    extras_require={
        'pandas': ['pandas', 'ipython'],
        'embedded': ['cozo-embedded==' + VERSION],
        'client': ['requests']
    },

I can easily put together a pull request for this, but I'm unsure whether you'd prefer to rename the extra or adjust the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant