Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale-specific failures on perl <= 5.20 #10

Open
eserte opened this issue Oct 17, 2020 · 7 comments
Open

Locale-specific failures on perl <= 5.20 #10

eserte opened this issue Oct 17, 2020 · 7 comments
Assignees
Labels
Patches Welcome! This is not something we plan to fix.

Comments

@eserte
Copy link

eserte commented Oct 17, 2020

t/test.t may fail on systems with non-English locale. Probably only older perls (< 5.20 or so) are affected:

    # Failed test 'No such file or directory.'
    # at t/test.t line 101.
    # +-------------------------------+----+-------------------------------+
    # | GOT                           | OP | CHECK                         |
    # +-------------------------------+----+-------------------------------+
    # | ( LAUNCH )  job  1    t/test- | =~ | (?^:No\ such\ file\ or\ direc |
    # | ok/pass-1.tx\n                |    | tory)                         |
    # | (  NOTE  )  job  1    Seeded  |    |                               |
    # | srand with seed '20201016' fr |    |                               |
    # | om local date.\n              |    |                               |
    # | [  PASS  ]  job  1  + pass\n  |    |                               |
    # | [  PLAN  ]  job  1    Expecte |    |                               |
    # | d assertions: 1\n             |    |                               |
    # | ( MEMORY )  job  1    rss:  N |    |                               |
    # | A\n                           |    |                               |
    # | ( MEMORY )  job  1    size: N |    |                               |
    # | A\n                           |    |                               |
    # | ( MEMORY )  job  1    peak: N |    |                               |
    # | A\n                           |    |                               |
    # | ( LAUNCH )  job  2    t/test- |    |                               |
    # | ok/pass-2.tx\n                |    |                               |
    # | ( PASSED )  job  1    t/test- |    |                               |
    # | ok/pass-1.tx\n                |    |                               |
    # | (  TIME  )  job  1    Startup |    |                               |
    # | : 0.38235s | Events: 0.00094s |    |                               |
    # |  | Cleanup: 0.00411s | Total: |    |                               |
    # |  0.38740s\n                   |    |                               |
    # | (  NOTE  )  job  2    Seeded  |    |                               |
    # | srand with seed '20201016' fr |    |                               |
    # | om local date.\n              |    |                               |
    # | [  PASS  ]  job  2  + pass\n  |    |                               |
    # | [  PLAN  ]  job  2    Expecte |    |                               |
    # | d assertions: 1\n             |    |                               |
    # | ( MEMORY )  job  2    rss:  N |    |                               |
    # | A\n                           |    |                               |
    # | ( MEMORY )  job  2    size: N |    |                               |
    # | A\n                           |    |                               |
    # | ( MEMORY )  job  2    peak: N |    |                               |
    # | A\n                           |    |                               |
    # | ( PASSED )  job  2    t/test- |    |                               |
    # | ok/pass-2.tx\n                |    |                               |
    # | (  TIME  )  job  2    Startup |    |                               |
    # | : 0.26109s | Events: 0.00125s |    |                               |
    # |  | Cleanup: 0.00305s | Total: |    |                               |
    # |  0.26539s\n                   |    |                               |
    # | Can't open '/var/tmp/cpansmok |    |                               |
    # | er-1023/2020101622/f4DcBrt_N0 |    |                               |
    # | /x/y/z/ok.xml' (Datei oder Ve |    |                               |
    # | rzeichnis nicht gefunden) at  |    |                               |
    # | /usr/perl5.14.4/lib/site_perl |    |                               |
    # | /5.14.4/Test2/Harness/Rendere |    |                               |
    # | r/JUnit.pm line 241, <$__ANON |    |                               |
    # | IO__> line 21.\n              |    |                               |
    # | \e[0m\n                       |    |                               |
    # +-------------------------------+----+-------------------------------+
    # Command = /usr/perl5.14.4/bin/perl /usr/perl5.14.4/bin/yath -D/usr/perl5.14.4/lib/site_perl/5.14.4 test -I/usr/perl5.14.4/lib/site_perl/5.14.4 t/test-ok --ext=tx --renderer=Formatter --renderer=JUnit -v
    # Exit = 512
    # ==== Output ====
    # ( LAUNCH )  job  1    t/test-ok/pass-1.tx
    # (  NOTE  )  job  1    Seeded srand with seed '20201016' from local date.
    # [  PASS  ]  job  1  + pass
    # [  PLAN  ]  job  1    Expected assertions: 1
    # ( MEMORY )  job  1    rss:  NA
    # ( MEMORY )  job  1    size: NA
    # ( MEMORY )  job  1    peak: NA
    # ( LAUNCH )  job  2    t/test-ok/pass-2.tx
    # ( PASSED )  job  1    t/test-ok/pass-1.tx
    # (  TIME  )  job  1    Startup: 0.38235s | Events: 0.00094s | Cleanup: 0.00411s | Total: 0.38740s
    # (  NOTE  )  job  2    Seeded srand with seed '20201016' from local date.
    # [  PASS  ]  job  2  + pass
    # [  PLAN  ]  job  2    Expected assertions: 1
    # ( MEMORY )  job  2    rss:  NA
    # ( MEMORY )  job  2    size: NA
    # ( MEMORY )  job  2    peak: NA
    # ( PASSED )  job  2    t/test-ok/pass-2.tx
    # (  TIME  )  job  2    Startup: 0.26109s | Events: 0.00125s | Cleanup: 0.00305s | Total: 0.26539s
    # Can't open '/var/tmp/cpansmoker-1023/2020101622/f4DcBrt_N0/x/y/z/ok.xml' (Datei oder Verzeichnis nicht gefunden) at /usr/perl5.14.4/lib/site_perl/5.14.4/Test2/Harness/Renderer/JUnit.pm line 241, <$__ANONIO__> line 21.
    # �[0m
    # 
    # ========
@toddr
Copy link
Member

toddr commented Oct 19, 2020

@atoomic Would you take a look at this please?

@toddr
Copy link
Member

toddr commented Oct 19, 2020

@atoomic
Copy link
Collaborator

atoomic commented Oct 19, 2020

at first glance the two issues are not linked each other

@atoomic
Copy link
Collaborator

atoomic commented Oct 19, 2020

I cannot reproduce this issue using for example LC_ALL=fr_FR prove -vl t/test.t and prove 5.14
I wonder if this is fixed by #12

@toddr
Copy link
Member

toddr commented Oct 19, 2020

You're probably right this is an issue but not a priority for me until I see evidence someone is using yath on 5.14 :)

@toddr toddr added the Patches Welcome! This is not something we plan to fix. label Oct 19, 2020
@toddr toddr changed the title Locale-specific failures Locale-specific failures on perl <= 5.14? Oct 19, 2020
@eserte
Copy link
Author

eserte commented Oct 20, 2020

I still see the failures with 1.000003. And it's not <= 5.14, but <= 5.20. A sample report: http://www.cpantesters.org/cpan/report/641dee58-1251-11eb-a408-ae391f24ea8f

@toddr
Copy link
Member

toddr commented Oct 20, 2020

Yep. Waiting on cpantesters to come back to life then I'll take a closer look. Thanks for your vigilance @eserte !!

@toddr toddr changed the title Locale-specific failures on perl <= 5.14? Locale-specific failures on perl <= 5.20 Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Patches Welcome! This is not something we plan to fix.
Development

No branches or pull requests

3 participants