Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the package maintainer ? #60

Open
db-tech opened this issue Aug 23, 2023 · 1 comment
Open

What is the package maintainer ? #60

db-tech opened this issue Aug 23, 2023 · 1 comment

Comments

@db-tech
Copy link

db-tech commented Aug 23, 2023

Hi,

I am trying to use your template for a project of mine.
Unfortunately, I am not sure I understand the definition of the package maintainer ( myproject_PACKAGING_MAINTAINER_MODE)

I the myproject_PACKAGING_MAINTAINER_MODE considered the build for production and the other is build in development ?

Why is WARNING_AS_ERRORS OFF by default ?
Why is ENAME_SANITIZER_** set within the if<->else ? Could this not just be defined in front of the if ?
Why is myproject_ENABLE_IPO be disabled on Package Maintainer mode ? Would't it make more sende to disable it in NON-PACKAGE_MAINTAINER mode ?

I would be really happy if someone could untangle my confusion a bit :-)

@db-tech db-tech changed the title What is the package maintainer What is the package maintainer ? Aug 23, 2023
@gostefan
Copy link

From my understanding the packaging maintainer mode should only be used by the developers of this package. I.e. we only want to enable additional checks for the developers.

I believe that there is a bug in this line: ProjectOptions.cmake
The condition should be NOT PROJECT_IS_TOP_LEVEL OR NOT myproject_PACKAGING_MAINTAINER_MODE. (Notice the second NOT.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants