Database Adjustment

[aljawaid]

I think this should be added to the plugin when creating a database table:

CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci

MetaMagik/Schema/Mysql.php

Line 65 in 80af9ab

) ENGINE=InnoDB CHARSET=utf8

MetaMagik/Schema/Mysql.php

Line 74 in 80af9ab

) ENGINE=InnoDB CHARSET=utf8

I noticed its not in the Postgres or SqLite files at all - not sure if its missing or meant to be like that.

[creecros]

Its MYSQL specific

[aljawaid]

I think this should be added to the plugin when creating a database table:

CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci

MetaMagik/Schema/Mysql.php

Line 65 in 80af9ab

) ENGINE=InnoDB CHARSET=utf8

MetaMagik/Schema/Mysql.php

Line 74 in 80af9ab

) ENGINE=InnoDB CHARSET=utf8

CHARSET and COLLATE seems to need to be changed in the MySQL file though.

[creecros]

Im not going to pretend to know anything. I took my ques from Kanboard itself:
https://github.com/kanboard/kanboard/blob/1e304f4ad6e3c9f55f1c766a2d2e1614201e4a64/app/Schema/Mysql.php#L272

[creecros]

and i dont have any issues. are there issues i am unaware of?

[aljawaid]

look at line 133 in the same file. It seems to be updated in later versions.

[aljawaid]

issues could be in updating and migrating. When I manually migrated mid-last year, one of my issues were the mysql tables were all the wrong charset and collation... noticeable, my conflict was plugins and it confused the hell out of me on which was correct and which was wrong/corrupted.

No issues right now, but I noticed it and thought I would let you know.

[creecros]

i see it now, thanks for pointing it out, looks like it should be done.

[creecros]

d763613