fix: Improper namespace application in elementToBytes #580
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
elemToBytes
function when applying namespaces to thedoc.Root()
it is assumed that the namespace will have a prefix. If the namespace is the default namespacexmlns
the function improperly applies the namespace as:xmlns:=<URI>
- which is invalid XML.This can cause errors when parsing Assertions that do not have explicit namespaces applied and inherit the default namespace from their parent element.
This PR updates the
elemToBytes
function to account for this.Related issues:
#578
#527