New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make re2 an optional peer dependency #34

Open

aldenquimby wants to merge 1 commit into crisp-oss:master from aldenquimby:master

aldenquimby commented Nov 21, 2024 •

edited

Loading

Fixes #33

Verified as follows:

npm run test

npm uninstall re2

npm run test

As of npm 8+, peer dependencies are automatically installed, so this should not impact consumers by default.

But anyone that wants to explicitly exclude re2 from their build process can now do so without this lib crashing.


          feat: make re2 an optional peer dependency

f164344

aldenquimby mentioned this pull request

Consider making re2 an optional dependency? #33

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet