Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository controller doesn't update ressource on password change #36

Closed
wotolom opened this issue Nov 29, 2022 · 2 comments · Fixed by #156
Closed

Repository controller doesn't update ressource on password change #36

wotolom opened this issue Nov 29, 2022 · 2 comments · Fixed by #156
Labels
bug Something isn't working

Comments

@wotolom
Copy link

wotolom commented Nov 29, 2022

What happened?

The isUpToDate method does not check if the password provided via secret changed.
The workaround is currently to trigger an update-call by changing another field in the repo claim.

How can we reproduce it?

Deploy secret with e.g. token, deploy repo referencing the secret (see example).
Write a new token in the secret or reference another secret with a new token.
-> no update call/request + new token is not being used

@wotolom wotolom added the bug Something isn't working label Nov 29, 2022
@github-actions
Copy link

Crossplane does not currently have enough maintainers to address every issue and pull request. This issue has been automatically marked as stale because it has had no activity in the last 90 days. It will be closed in 7 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

@oskisk
Copy link
Contributor

oskisk commented Mar 27, 2024

/fresh

I would like to contribute to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants