Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Repository secret observation #156

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

oskisk
Copy link
Contributor

@oskisk oskisk commented Mar 29, 2024

Description of your changes

Trigger a resource update on secret changes for all the references within the repository controller.

Fixes #36

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

  • Added basic unit tests for the repository controllers
  • manual testing for referenes and observations

@oskisk
Copy link
Contributor Author

oskisk commented Apr 4, 2024

@MisterMX Would you have time to review this PR?

Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @oskisk! I made some minor remarks. Can you take a look at them?

pkg/controller/repositories/controller.go Outdated Show resolved Hide resolved
pkg/controller/repositories/controller.go Outdated Show resolved Hide resolved
Signed-off-by: Armin Barton <armin.barton@dynatrace.com>
@oskisk
Copy link
Contributor Author

oskisk commented Apr 9, 2024

Thanks for this PR @oskisk! I made some minor remarks. Can you take a look at them?

Thank you for reviewing. I've made the changes to the branch based on your suggestions.

@oskisk oskisk requested a review from MisterMX April 9, 2024 08:39
@nikolainespor
Copy link

@MisterMX could you review the last changes from @oskisk ?

Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much @oskisk!

@MisterMX MisterMX merged commit d70d68d into crossplane-contrib:main Apr 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repository controller doesn't update ressource on password change
3 participants