Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The code is missing all the inlines #673

Open
keks opened this issue Nov 13, 2024 · 0 comments · May be fixed by #703
Open

The code is missing all the inlines #673

keks opened this issue Nov 13, 2024 · 0 comments · May be fixed by #703

Comments

@keks
Copy link
Member

keks commented Nov 13, 2024

That's also why you didn't run into build performance issues. We should annotate all functions with a must inline in the hacl-rs code. Otherwise this code will be slow.

Prompted by #659 (review)
@keks keks linked a pull request Dec 2, 2024 that will close this issue
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up Hacl-rs integration and add Poly1305 and ChaCha20Poly1305 cryspen/libcrux
1 participant
@keks