darwin 1.5.1 build has broken symlink

[elthariel]

Hi,

It seems there's a broken symlink in the 1.5.1 darwin build : embedded/lib/libffi.dylib points to a non-existent file with a names referencing the previous crystal release.

There are also a lot of other broken symlinks in the distribution (manpages and such). This isn't critical really, but it's worth noting as they're breaking our build system (so we're nicely deleting them).

<3 <3 <3

[straight-shoota]

Thanks for reporting.

https://github.com/crystal-lang/crystal/releases/download/1.5.1/crystal-1.5.1-1-darwin-universal.tar.gz contains the following broken links:

./src/lib_c/amd64-unknown-openbsd -> crystal-1.5.1-186_64-openbsd
./src/lib_c/x86_64-portbld-freebsd -> crystal-1.5.1-186_64-freebsd
./src/lib_c/i686-linux-musl -> crystal-1.5.1-1386-linux-musl
./src/lib_c/x86_64-unknown-freebsd -> crystal-1.5.1-186_64-freebsd
./src/lib_c/i686-linux-gnu -> crystal-1.5.1-1386-linux-gnu
./src/lib_c/x86_64-macosx-darwin -> crystal-1.5.1-186_64-darwin
./embedded/lib/libffi.dylib -> crystal-1.5.1-1ibffi.8.dylib
./embedded/share/man/man3/pcre16_get_named_substring.3 -> crystal-1.5.1-1cre_get_named_substring.3
./embedded/share/man/man3/pcre16_free_study.3 -> crystal-1.5.1-1cre_free_study.3
./embedded/share/man/man3/pcre16_copy_named_substring.3 -> crystal-1.5.1-1cre_copy_named_substring.3
./embedded/share/man/man3/pcre32_version.3 -> crystal-1.5.1-1cre_version.3
./embedded/share/man/man3/pcre32_utf32_to_host_byte_order.3 -> crystal-1.5.1-1cre_utf32_to_host_byte_order.3
./embedded/share/man/man3/pcre16_version.3 -> crystal-1.5.1-1cre_version.3
./embedded/share/man/man3/pcre16_exec.3 -> crystal-1.5.1-1cre_exec.3
./embedded/share/man/man3/pcre32_compile.3 -> crystal-1.5.1-1cre_compile.3
./embedded/share/man/man3/pcre16_compile2.3 -> crystal-1.5.1-1cre_compile2.3
./embedded/share/man/man3/pcre32_get_stringnumber.3 -> crystal-1.5.1-1cre_get_stringnumber.3
./embedded/share/man/man3/pcre16_get_substring_list.3 -> crystal-1.5.1-1cre_get_substring_list.3
./embedded/share/man/man3/pcre32_get_stringtable_entries.3 -> crystal-1.5.1-1cre_get_stringtable_entries.3
./embedded/share/man/man3/pcre32_copy_named_substring.3 -> crystal-1.5.1-1cre_copy_named_substring.3
./embedded/share/man/man3/pcre16_refcount.3 -> crystal-1.5.1-1cre_refcount.3
./embedded/share/man/man3/pcre16_jit_stack_alloc.3 -> crystal-1.5.1-1cre_jit_stack_alloc.3
./embedded/share/man/man3/pcre32_study.3 -> crystal-1.5.1-1cre_study.3
./embedded/share/man/man3/pcre16_fullinfo.3 -> crystal-1.5.1-1cre_fullinfo.3
./embedded/share/man/man3/pcre32_config.3 -> crystal-1.5.1-1cre_config.3
./embedded/share/man/man3/pcre16_jit_exec.3 -> crystal-1.5.1-1cre_jit_exec.3
./embedded/share/man/man3/pcre16_dfa_exec.3 -> crystal-1.5.1-1cre_dfa_exec.3
./embedded/share/man/man3/pcre32_get_named_substring.3 -> crystal-1.5.1-1cre_get_named_substring.3
./embedded/share/man/man3/pcre32_jit_stack_free.3 -> crystal-1.5.1-1cre_jit_stack_free.3
./embedded/share/man/man3/pcre16_compile.3 -> crystal-1.5.1-1cre_compile.3
./embedded/share/man/man3/pcre32_assign_jit_stack.3 -> crystal-1.5.1-1cre_assign_jit_stack.3
./embedded/share/man/man3/pcre32_fullinfo.3 -> crystal-1.5.1-1cre_fullinfo.3
./embedded/share/man/man3/pcre16_assign_jit_stack.3 -> crystal-1.5.1-1cre_assign_jit_stack.3
./embedded/share/man/man3/pcre32_free_substring.3 -> crystal-1.5.1-1cre_free_substring.3
./embedded/share/man/man3/pcre32_pattern_to_host_byte_order.3 -> crystal-1.5.1-1cre_pattern_to_host_byte_order.3
./embedded/share/man/man3/pcre16_pattern_to_host_byte_order.3 -> crystal-1.5.1-1cre_pattern_to_host_byte_order.3
./embedded/share/man/man3/pcre16_utf16_to_host_byte_order.3 -> crystal-1.5.1-1cre_utf16_to_host_byte_order.3
./embedded/share/man/man3/pcre32_free_study.3 -> crystal-1.5.1-1cre_free_study.3
./embedded/share/man/man3/pcre32_maketables.3 -> crystal-1.5.1-1cre_maketables.3
./embedded/share/man/man3/pcre32_refcount.3 -> crystal-1.5.1-1cre_refcount.3
./embedded/share/man/man3/pcre16_copy_substring.3 -> crystal-1.5.1-1cre_copy_substring.3
./embedded/share/man/man3/pcre32_jit_stack_alloc.3 -> crystal-1.5.1-1cre_jit_stack_alloc.3
./embedded/share/man/man3/pcre16_free_substring.3 -> crystal-1.5.1-1cre_free_substring.3
./embedded/share/man/man3/pcre16_maketables.3 -> crystal-1.5.1-1cre_maketables.3
./embedded/share/man/man3/pcre16_jit_stack_free.3 -> crystal-1.5.1-1cre_jit_stack_free.3
./embedded/share/man/man3/pcre16_study.3 -> crystal-1.5.1-1cre_study.3
./embedded/share/man/man3/pcre32_exec.3 -> crystal-1.5.1-1cre_exec.3
./embedded/share/man/man3/pcre16_get_substring.3 -> crystal-1.5.1-1cre_get_substring.3
./embedded/share/man/man3/pcre32_jit_exec.3 -> crystal-1.5.1-1cre_jit_exec.3
./embedded/share/man/man3/pcre16_get_stringtable_entries.3 -> crystal-1.5.1-1cre_get_stringtable_entries.3
./embedded/share/man/man3/pcre32_free_substring_list.3 -> crystal-1.5.1-1cre_free_substring_list.3
./embedded/share/man/man3/pcre32_get_substring.3 -> crystal-1.5.1-1cre_get_substring.3
./embedded/share/man/man3/pcre16_get_stringnumber.3 -> crystal-1.5.1-1cre_get_stringnumber.3
./embedded/share/man/man3/pcre32_get_substring_list.3 -> crystal-1.5.1-1cre_get_substring_list.3
./embedded/share/man/man3/pcre16_config.3 -> crystal-1.5.1-1cre_config.3
./embedded/share/man/man3/pcre16_free_substring_list.3 -> crystal-1.5.1-1cre_free_substring_list.3
./embedded/share/man/man3/pcre32_compile2.3 -> crystal-1.5.1-1cre_compile2.3
./embedded/share/man/man3/pcre32_copy_substring.3 -> crystal-1.5.1-1cre_copy_substring.3
./embedded/share/man/man3/pcre32_dfa_exec.3 -> crystal-1.5.1-1cre_dfa_exec.3

I have no idea where that comes from. It seems like the first characters of each target file name is replaced by crystal-1.5.1-1 for some reason.

/cc @bcardiff Any idea?

[askz]

I can confirm that the bug is present on earlier version packages too.